src: remove editing leftovers from options help text#22636
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
src: remove editing leftovers from options help text#22636addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
c++
richardlau
approved these changes
Sep 1, 2018
BridgeAR
approved these changes
Sep 1, 2018
BridgeAR
added
the
author ready
Member
|
CI https://ci.nodejs.org/job/node-test-pull-request/16918/ (:heavy_check_mark:) |
cjihrig
approved these changes
Sep 1, 2018
lpinca
approved these changes
Sep 1, 2018
jasnell
approved these changes
Sep 4, 2018
trivikr
approved these changes
Sep 4, 2018
This was referenced Sep 4, 2018
Contributor
|
Landed in 65f0323. |
danbev
pushed a commit
that referenced
this pull request
Sep 5, 2018
PR-URL: #22636 Refs: https://github.com/nodejs/node/commit/ 85212bb#r30265305 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 5, 2018
PR-URL: #22636 Refs: https://github.com/nodejs/node/commit/ 85212bb#r30265305 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2018
PR-URL: #22636 Refs: https://github.com/nodejs/node/commit/ 85212bb#r30265305 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Sep 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: 85212bb#r30265305
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes